aides-infra/aides-repo-api
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: reduce memory usage
Some checks failed
Format and Lint / format-check (push) Failing after 4s
Details
Format and Lint / test (push) Successful in 53s
Details

Browse source
This commit is contained in:
Максим Слипенко 2025-01-08 15:30:48 +03:00
parent 0d56779189
commit 939f14eb86
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
internal/controllers/taskcontroller/upload.go
View file

@ -46,7 +46,7 @@ func (c *TaskController) Upload(w http.ResponseWriter, r *http.Request) {
return return
} }
err := r.ParseMultipartForm(10240 << 20) err := r.ParseMultipartForm(10 << 20)
if err != nil { if err != nil {
render.Render(w, r, &commonErrors.ErrResponse{ render.Render(w, r, &commonErrors.ErrResponse{
HTTPStatusCode: http.StatusBadRequest, HTTPStatusCode: http.StatusBadRequest,
@ -57,7 +57,7 @@ func (c *TaskController) Upload(w http.ResponseWriter, r *http.Request) {
files := r.MultipartForm.File["files"] files := r.MultipartForm.File["files"]
for _, fileHeader := range files { for _, fileHeader := range files {
if fileHeader.Size > (1024 << 20) { if fileHeader.Size > (4096 << 20) {
render.Render(w, r, &commonErrors.ErrResponse{ render.Render(w, r, &commonErrors.ErrResponse{
HTTPStatusCode: http.StatusBadRequest, HTTPStatusCode: http.StatusBadRequest,
StatusText: "File too large", StatusText: "File too large",

4
internal/services/taskservice/upload.go
View file

@ -86,7 +86,6 @@ func (s *Service) Upload(input *TaskUploadInput) error {
if err != nil { if err != nil {
return fmt.Errorf("can't open fileHeader %w", err) return fmt.Errorf("can't open fileHeader %w", err)
} }
defer file.Close()
if !strings.HasSuffix(fileHeader.Filename, ".rpm") { if !strings.HasSuffix(fileHeader.Filename, ".rpm") {
return fmt.Errorf("invalid file type: only .rpm files are allowed") return fmt.Errorf("invalid file type: only .rpm files are allowed")
@ -107,12 +106,13 @@ func (s *Service) Upload(input *TaskUploadInput) error {
if err != nil { if err != nil {
return err return err
} }
defer outFile.Close()
_, err = io.Copy(outFile, file) _, err = io.Copy(outFile, file)
if err != nil { if err != nil {
return err return err
} }
outFile.Close()
file.Close()
pkg, err := rpm.Open(filePath) pkg, err := rpm.Open(filePath)
if err != nil { if err != nil {